Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Documenter #34

Merged
merged 5 commits into from
May 6, 2019
Merged

Setup Documenter #34

merged 5 commits into from
May 6, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented May 6, 2019

This PR sets up Documenter. I leave out deploydocs setup so you still need to do the usual Travis setup.

I'm sending this PR because it would motivate me to write docstring next time I send a feature PR :)

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   56.61%   56.61%           
=======================================
  Files          15       15           
  Lines         952      952           
=======================================
  Hits          539      539           
  Misses        413      413
Impacted Files Coverage Δ
src/LazyArrays.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2f6ce...40e7a50. Read the comment docs.

@dlfivefifty dlfivefifty merged commit 8f3d8eb into JuliaArrays:master May 6, 2019
@dlfivefifty
Copy link
Member

Unfortunately I don't have time to work on docs right now, but I've added you as a collaborator so feel free to merge whatever you feel doesn't require a review.

Note that it might be worth waiting to the code settles down a bit more. For example:

#35
#33

and also I'm thinking that BroadcastArray and ApplyArray should not wrap a Broadcasted and Applied instance, instead have the same fields (and so make dispatch a bit simpler).

@tkf
Copy link
Member Author

tkf commented May 6, 2019

I've added you as a collaborator

Thanks!

I don't think that's enough access to setup Travis/Documenter. It's not urgent at all, but can you do it when you have time #36?

BroadcastArray and ApplyArray should not wrap a Broadcasted and Applied instance, instead have the same fields

I think it makes sense.

@tkf tkf mentioned this pull request May 7, 2019
@tkf tkf deleted the docs branch June 26, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants