Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SparseArrays dependency to extension #365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j-fu
Copy link

@j-fu j-fu commented Feb 11, 2025

This should help to resolve SciML/LinearSolve.jl#573

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.66%. Comparing base (7810cf5) to head (c8c9a23).

Files with missing lines Patch % Lines
src/lazyoperations.jl 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   95.72%   95.66%   -0.06%     
==========================================
  Files          17       18       +1     
  Lines        3204     3210       +6     
==========================================
+ Hits         3067     3071       +4     
- Misses        137      139       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

"my_" is a very bad naming convention. I have no idea what these are for!

@j-fu
Copy link
Author

j-fu commented Feb 12, 2025

Well the idea is to have some issparse and nnz methods which defaults to false in the case SparseArrays is not loaded, and is extended with the ones from SparseArrays in the extensions. Do you agree with the general approach ?

Instead of "my_" we could use "", "tentative" "local_" "provisional_" "preliminary_" ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency on 1.10
2 participants