Memory pool improvements #1383
Merged
Memory pool improvements #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids querying the current context, which may cause a task switch.
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
+ Coverage 77.96% 78.00% +0.03%
==========================================
Files 121 121
Lines 8960 8946 -14
==========================================
- Hits 6986 6978 -8
+ Misses 1974 1968 -6
Continue to review full report at Codecov.
|
Merged
maleadt
added a commit
that referenced
this pull request
Apr 5, 2022
For some reason, the thread-bound context can become desynchronized from the task-local one. Generally we don't notice this, because we prefix every API call with a call that synchronizes both. Here, however, we explicitly didn't to avoid initializing the state as that was thought to cause the kind of initialization that may have to yield (which is unsupported when done so from a finalizer). However, just creating the task local state shouldn't result in yield, only creating a stream does, like querying `active_state` as was done before #1383.
maleadt
added a commit
that referenced
this pull request
May 9, 2022
For some reason, the thread-bound context can become desynchronized from the task-local one. Generally we don't notice this, because we prefix every API call with a call that synchronizes both. Here, however, we explicitly didn't to avoid initializing the state as that was thought to cause the kind of initialization that may have to yield (which is unsupported when done so from a finalizer). However, just creating the task local state shouldn't result in yield, only creating a stream does, like querying `active_state` as was done before #1383.
maleadt
added a commit
that referenced
this pull request
May 9, 2022
…1462) For some reason, the thread-bound context can become desynchronized from the task-local one. Generally we don't notice this, because we prefix every API call with a call that synchronizes both. Here, however, we explicitly didn't to avoid initializing the state as that was thought to cause the kind of initialization that may have to yield (which is unsupported when done so from a finalizer). However, just creating the task local state shouldn't result in yield, only creating a stream does, like querying `active_state` as was done before #1383.
simonbyrne
pushed a commit
to simonbyrne/CUDA.jl
that referenced
this pull request
Nov 13, 2023
…uliaGPU#1462) For some reason, the thread-bound context can become desynchronized from the task-local one. Generally we don't notice this, because we prefix every API call with a call that synchronizes both. Here, however, we explicitly didn't to avoid initializing the state as that was thought to cause the kind of initialization that may have to yield (which is unsupported when done so from a finalizer). However, just creating the task local state shouldn't result in yield, only creating a stream does, like querying `active_state` as was done before JuliaGPU#1383.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1384