-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bfloat16 support #446
Draft
christiangnrd
wants to merge
1
commit into
main
Choose a base branch
from
bfloat16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bfloat16 support #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess no point testing this on macOS 13. Will update this to run CI on Sequoia for draft PRs once the MIT runners are back available. |
Will try again once LLVM 17+ are supported as I suspect intrinsic support for bfloat16 is needed to generate the proper code. |
8fc9b1c
to
52df368
Compare
a908305
to
caf8f9d
Compare
caf8f9d
to
6e401bc
Compare
406a046
to
3f746c6
Compare
5a8daaa
to
b9610e3
Compare
3f746c6
to
3b65d79
Compare
6d983a0
to
c626d99
Compare
42408c9
to
89f6755
Compare
bfccc57
to
76f635f
Compare
00b64b3
to
381df18
Compare
cf56ea3
to
be67cff
Compare
be67cff
to
34fa83d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed BFloat16s.jl to a hard dependency as it seems to be a very light and it greatly simplified implementation.
I can't figure out the simdgroup multiply failures.
Todo:
Closes #298