Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .git-blame-ignore-revs and a few other fixes #541

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

christiangnrd
Copy link
Contributor

  • Adds .git-blame-ignore-revs with Whitespace fixes #346 as the first commit to ignore and recommends setting it as a revision ignore file locally.
  • Fix a typo that wasn't caught because we don't support macOS 11
  • Remove argument name in 2 functions where said argument isn't used
  • Adds Runic annotations to avoid formatting the spaces alignment.

This is in preparation for a big formatting PR I have planned, but is independently an improvement.

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (52d7056) to head (94a3889).
Report is 420 commits behind head on main.

Files with missing lines Patch % Lines
src/compiler/execution.jl 0.00% 2 Missing ⚠️
src/version.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   71.04%   74.88%   +3.84%     
==========================================
  Files          36       57      +21     
  Lines        1143     2708    +1565     
==========================================
+ Hits          812     2028    +1216     
- Misses        331      680     +349     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal Benchmarks

Benchmark suite Current: 94a3889 Previous: 3ad45e2 Ratio
private array/construct 23902.75 ns 25757 ns 0.93
private array/broadcast 464250 ns 458750 ns 1.01
private array/random/randn/Float32 903333 ns 799063 ns 1.13
private array/random/randn!/Float32 597375 ns 631750 ns 0.95
private array/random/rand!/Int64 558083 ns 569458 ns 0.98
private array/random/rand!/Float32 555917 ns 590625 ns 0.94
private array/random/rand/Int64 896270.5 ns 771521 ns 1.16
private array/random/rand/Float32 801729.5 ns 615041.5 ns 1.30
private array/copyto!/gpu_to_gpu 574125 ns 663291 ns 0.87
private array/copyto!/cpu_to_gpu 721833 ns 823500 ns 0.88
private array/copyto!/gpu_to_cpu 689479.5 ns 810750 ns 0.85
private array/accumulate/1d 1421125 ns 1335667 ns 1.06
private array/accumulate/2d 1485208 ns 1389791 ns 1.07
private array/iteration/findall/int 2285958.5 ns 2080687.5 ns 1.10
private array/iteration/findall/bool 1995187.5 ns 1813312.5 ns 1.10
private array/iteration/findfirst/int 1790646 ns 1704334 ns 1.05
private array/iteration/findfirst/bool 1731042 ns 1661875 ns 1.04
private array/iteration/scalar 2521042 ns 3891459 ns 0.65
private array/iteration/logical 3512459 ns 3201499.5 ns 1.10
private array/iteration/findmin/1d 1870875 ns 1769208 ns 1.06
private array/iteration/findmin/2d 1409833 ns 1355958 ns 1.04
private array/reductions/reduce/1d 984875 ns 1032375 ns 0.95
private array/reductions/reduce/2d 693291.5 ns 680584 ns 1.02
private array/reductions/mapreduce/1d 1000583 ns 1028083 ns 0.97
private array/reductions/mapreduce/2d 698042 ns 660625 ns 1.06
private array/permutedims/4d 2647042 ns 2485291 ns 1.07
private array/permutedims/2d 1088020.5 ns 1027417 ns 1.06
private array/permutedims/3d 1817083.5 ns 1583167 ns 1.15
private array/copy 849896 ns 607062.5 ns 1.40
latency/precompile 9230222084 ns 9206066500 ns 1.00
latency/ttfp 3722193750 ns 3620935333 ns 1.03
latency/import 1258588937.5 ns 1245867333 ns 1.01
integration/metaldevrt 756709 ns 714833 ns 1.06
integration/byval/slices=1 1666959 ns 1636083 ns 1.02
integration/byval/slices=3 19331208.5 ns 9396937.5 ns 2.06
integration/byval/reference 1668312.5 ns 1512312.5 ns 1.10
integration/byval/slices=2 2776541.5 ns 2672792 ns 1.04
kernel/indexing 460625 ns 476292 ns 0.97
kernel/indexing_checked 465875 ns 457062.5 ns 1.02
kernel/launch 8854 ns 8125 ns 1.09
metal/synchronization/stream 14917 ns 14500 ns 1.03
metal/synchronization/context 15333 ns 14625 ns 1.05
shared array/construct 23513.833333333332 ns 24527.75 ns 0.96
shared array/broadcast 463375 ns 463125 ns 1.00
shared array/random/randn/Float32 943208 ns 751125 ns 1.26
shared array/random/randn!/Float32 603667 ns 643000 ns 0.94
shared array/random/rand!/Int64 556375 ns 564791.5 ns 0.99
shared array/random/rand!/Float32 565708.5 ns 606833 ns 0.93
shared array/random/rand/Int64 936625 ns 757458 ns 1.24
shared array/random/rand/Float32 825625.5 ns 591063 ns 1.40
shared array/copyto!/gpu_to_gpu 80792 ns 83292 ns 0.97
shared array/copyto!/cpu_to_gpu 81292 ns 82875 ns 0.98
shared array/copyto!/gpu_to_cpu 79959 ns 82375 ns 0.97
shared array/accumulate/1d 1436208 ns 1357021 ns 1.06
shared array/accumulate/2d 1488187.5 ns 1394062.5 ns 1.07
shared array/iteration/findall/int 2017333 ns 1827750 ns 1.10
shared array/iteration/findall/bool 1741667 ns 1569521 ns 1.11
shared array/iteration/findfirst/int 1491959 ns 1395062.5 ns 1.07
shared array/iteration/findfirst/bool 1427458 ns 1371375.5 ns 1.04
shared array/iteration/scalar 160354.5 ns 154041.5 ns 1.04
shared array/iteration/logical 3254312.5 ns 2998937.5 ns 1.09
shared array/iteration/findmin/1d 1556375 ns 1464375 ns 1.06
shared array/iteration/findmin/2d 1426417 ns 1369562.5 ns 1.04
shared array/reductions/reduce/1d 722375 ns 733959 ns 0.98
shared array/reductions/reduce/2d 712500 ns 669708 ns 1.06
shared array/reductions/mapreduce/1d 726792 ns 746959 ns 0.97
shared array/reductions/mapreduce/2d 708792 ns 671916 ns 1.05
shared array/permutedims/4d 2657646 ns 2542083.5 ns 1.05
shared array/permutedims/2d 1088417 ns 1021500 ns 1.07
shared array/permutedims/3d 1798166.5 ns 1581791 ns 1.14
shared array/copy 212708 ns 251729 ns 0.84

This comment was automatically generated by workflow using github-action-benchmark.

@maleadt
Copy link
Member

maleadt commented Feb 14, 2025

Part of the idea of Runic only running on diffs is that we don't need annotations. Also, do those still work given the way git runic invokes Runic in range mode, given that it is built on top of annotations as well?

@christiangnrd
Copy link
Contributor Author

@maleadt Good point, I've removed the annotations.

@maleadt maleadt merged commit bec8c71 into JuliaGPU:main Feb 14, 2025
7 checks passed
@christiangnrd christiangnrd deleted the blameprep branch February 14, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants