Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Universe_size #280

Merged
merged 12 commits into from
Jul 1, 2019
Merged

Add Universe_size #280

merged 12 commits into from
Jul 1, 2019

Conversation

bn222
Copy link
Contributor

@bn222 bn222 commented Jun 27, 2019

As part of development of MPIExecutor.jl, a package inspired by mpi4py that I'm working on, I need to be able to get the universe size to provide sane defaults.

Copy link
Member

@simonbyrne simonbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be good to add a test and docstring if possible.

Balazs Nemeth and others added 6 commits June 28, 2019 09:59
Co-Authored-By: Simon Byrne <[email protected]>
Co-Authored-By: Simon Byrne <[email protected]>
Co-Authored-By: Simon Byrne <[email protected]>
Co-Authored-By: Simon Byrne <[email protected]>
Co-Authored-By: Simon Byrne <[email protected]>
@simonbyrne
Copy link
Member

Looks like MPICH doesn't define it unless specified as part of mpiexec or as an environment variable.

@bn222
Copy link
Contributor Author

bn222 commented Jun 28, 2019 via email

@simonbyrne
Copy link
Member

Supposedly MPICH should allow setting the universe size by the MPIEXEC_UNIVERSE_SIZE environment variable, but I couldn't get it to work.

Instead I changed it to return nothing if the attribute is not defined. Also since it is only attached tgo MPI.COMM_WORLD, I just made it a zero-argument function.

@simonbyrne
Copy link
Member

@beltedmetric Does this work for you?

@bn222
Copy link
Contributor Author

bn222 commented Jul 1, 2019 via email

@simonbyrne simonbyrne merged commit 7de5bf3 into JuliaParallel:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants