Implement automatically serializing scatter
#758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
reviewed
Jul 29, 2023
src/collective.jl
Outdated
| counts = length.(datasegments) | ||
|
|
||
| count = Scatter(counts, Int64, comm; root = root) | ||
| sendbuf = VBuffer(vcat(datasegments...), counts) |
There was a problem hiding this comment.
Splatting vectors is generally a bad idea.
The optimal approach would be to incrementally serialize to a single buffer, but at the minimum we should call reduce:
Suggested change
| sendbuf = VBuffer(vcat(datasegments...), counts) | |
| sendbuf = VBuffer(reduce(vcat, datasegments), counts) |
|
Whoopsie, I was always wondering about the preferred way to do that. But here is a version that uses a single buffer. Don’t know if there is a better way to calculate the counts. |
simonbyrne
approved these changes
Jul 30, 2023
|
thank you! |
|
I've sent an invite to give you commit access. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging the
gatherpull request! I went ahead and implementedscatteras well!The current version does a tiny amount of unnecessary work by serializing
objs[root + 1], which is never sent. I figured saving this might not be worth the additional complexity. Happy to implement it that way though.