chore: improve error handling in upgrades

KYVENetwork · Apr 24, 2024 · 256ffc5 · 256ffc5
1 parent 9878c63
commit 256ffc5
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/app/upgrades/v1_5/upgrade.go b/app/upgrades/v1_5/upgrade.go
@@ -25,15 +25,17 @@ func CreateUpgradeHandler(mm *module.Manager, configurator module.Configurator,
 		logger := sdk.UnwrapSDKContext(ctx).Logger().With("upgrade", UpgradeName)
 		logger.Info(fmt.Sprintf("performing upgrade %v", UpgradeName))
 
-		migrateStorageCosts(ctx, bundlesKeeper, poolKeeper, storeKeys, cdc)
+		if err := migrateStorageCosts(ctx, bundlesKeeper, poolKeeper, storeKeys, cdc); err != nil {
+			return nil, err
+		}
 
 		// TODO: migrate gov params
 
 		return mm.RunMigrations(ctx, configurator, fromVM)
 	}
 }
 
-func migrateStorageCosts(ctx context.Context, bundlesKeeper keeper.Keeper, poolKeeper *poolkeeper.Keeper, storeKeys []storetypes.StoreKey, cdc codec.Codec) {
+func migrateStorageCosts(ctx context.Context, bundlesKeeper keeper.Keeper, poolKeeper *poolkeeper.Keeper, storeKeys []storetypes.StoreKey, cdc codec.Codec) error {
 	sdkCtx := sdk.UnwrapSDKContext(ctx)
 
 	var bundlesStoreKey storetypes.StoreKey
@@ -44,7 +46,7 @@ func migrateStorageCosts(ctx context.Context, bundlesKeeper keeper.Keeper, poolK
 		}
 	}
 	if bundlesStoreKey == nil {
-		panic("bundles store key not found")
+		return fmt.Errorf("store key not found: bundles")
 	}
 
 	// Get all storage providers
@@ -69,4 +71,5 @@ func migrateStorageCosts(ctx context.Context, bundlesKeeper keeper.Keeper, poolK
 	}
 
 	bundlesKeeper.SetParams(sdkCtx, newParams)
+	return nil
 }