Add functionality to allow the scaling of shadows #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the suggested improvement raised in Issue #111 - Entity shadows: should they scale alongside the entity?
We've added a new flag -
scaleShadow- to themixin/entity.jsfile which will allow developers to switch on this new functionality for entitys. We've updated the demo tests canvas-060 to canvas-068 so we can test the new functionality.Note the flag is set to default to
false- this is to minimise the impact of the update on existing projectsscaleShadow = false
Screen.Recording.2025-02-02.at.12.30.16.mov
scaleShadow = true
Screen.Recording.2025-02-02.at.12.31.00.mov