Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MRT_TableBodyEmptyRow component to render when table has no rows #445

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

EdwardEB
Copy link
Contributor

Replace component in MRT_TableBody with MRT_TableBodyEmptyRow component, that renders a MRT_TableBodyRow when table has no rows, and can be built on and improved in the future.

By doing this, the row that renders when the table is empty has the same props as an actual data row and would add consistency, flexibility, and the ability to use features like the detail panel.

Also added EmptyRow stories, to showcase the possible uses.

Copy link

vercel bot commented Nov 19, 2024

@EdwardEB is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@alessandrojcm
Copy link
Collaborator

LGTM @KevinVandy I know you were a bit hesitant over discord about this, however I think these are valid use cases. @EdwardEB on top of the couple of comments that I left there: 1) Could you please update the examples to use the useMantineReactTable hook? 2) Add the new component to the src/index.ts barrel file, thanks!

@EdwardEB
Copy link
Contributor Author

@alessandrojcm I've made the changes you requested, but I could not find any comments on the files changed? Did you leave comments somewhere else that I may have missed?

@alessandrojcm
Copy link
Collaborator

@alessandrojcm I've made the changes you requested, but I could not find any comments on the files changed? Did you leave comments somewhere else that I may have missed?

Sorry I always forget to click start review check now please

@alessandrojcm alessandrojcm self-requested a review December 1, 2024 20:55
Copy link
Collaborator

@alessandrojcm alessandrojcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@alessandrojcm alessandrojcm merged commit 58083ae into KevinVandy:v2 Dec 1, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants