-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MRT_TableBodyEmptyRow component to render when table has no rows #445
Conversation
…Row, not just a tr
@EdwardEB is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
LGTM @KevinVandy I know you were a bit hesitant over discord about this, however I think these are valid use cases. @EdwardEB on top of the couple of comments that I left there: 1) Could you please update the examples to use the |
@alessandrojcm I've made the changes you requested, but I could not find any comments on the files changed? Did you leave comments somewhere else that I may have missed? |
packages/mantine-react-table/stories/features/EmptyRow.stories.tsx
Outdated
Show resolved
Hide resolved
packages/mantine-react-table/stories/features/EmptyRow.stories.tsx
Outdated
Show resolved
Hide resolved
Sorry I always forget to click start review check now please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
Replace component in MRT_TableBody with MRT_TableBodyEmptyRow component, that renders a MRT_TableBodyRow when table has no rows, and can be built on and improved in the future.
By doing this, the row that renders when the table is empty has the same props as an actual data row and would add consistency, flexibility, and the ability to use features like the detail panel.
Also added EmptyRow stories, to showcase the possible uses.