Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Fix #119: Ensure a multipart Content-Type header is used when sending attachments. #120

Merged
merged 2 commits into from
Jul 19, 2016

Conversation

n1k0
Copy link
Contributor

@n1k0 n1k0 commented Jul 19, 2016

Refs #119. This is ugly, but I couldn't find any better generic way to check for a multipart request body 😞

Tested the patch on kinto-admin, solves the issue.

r=? @leplatrem

@n1k0 n1k0 force-pushed the 119-fix-attachment-req-content-type branch from 1a5998e to 86ac856 Compare July 19, 2016 07:25
@@ -20,6 +20,8 @@ kinto.attachment.folder = {bucket_id}/{collection_id}
kinto.attachment.keep_old_files = true
kinto.attachment.base_path = /tmp

kinto.experimental_permissions_endpoint = true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: leftover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, good catch

@leplatrem
Copy link
Contributor

r+

@n1k0 n1k0 merged commit 76b64c5 into master Jul 19, 2016
@n1k0 n1k0 deleted the 119-fix-attachment-req-content-type branch July 19, 2016 07:46
n1k0 added a commit that referenced this pull request Jul 19, 2016
Fix #119: Ensure sending multipart content-type along attachments (#120)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants