-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gapfilling not giving any solutions #653
Comments
Hi! just to be sure, what's I assume model = ecoli = load_model(StandardModel, "iML1515.json") and the |
OK, as an observation the With the model and ecoli loaded as above, I get: julia> a
Dict{String, Float64} with 2713 entries:
"PACOAT" => 18.2651
"Zn2tex" => 0.142092
"GUI1" => -25.4034
"DXYLK" => 0.0
"FE3DCITtonex" => 9.96505
"METSOXR1" => -32.3627
"FACOAL180t2pp" => -50.5778
"CBL1tonex" => 10.7797
"LIPOtex" => -0.0159199
"NTD11" => -159.944
"GLUNpp" => 134.854
"ORNDC" => -55.5699
"UAGCVT" => -107.138
"ALAGLUE" => -6.79532
"I2FE2ST" => 10.8841
"BMOCOS" => 3.69732e-16
"6D6SPA" => -46.1326
"GLCURt2rpp" => 26.0364
"EX_g3pg_e" => -34.1899
"PGSA141" => -31.9436
"GMPS2" => 35.7147
"RNDR2b" => -7.69883
"NMNPtpp" => 42.8984
"EX_gua_e" => -10.9186
"ACGK" => -59.7721
⋮ => ⋮
julia> a["BIOMASS_Ec_iML1515_core_75p37M"]
999.9999979361254
julia> gapfilled_rids(m,ecoli_rxns)
String[] |
Hey! I couldn't upload a .json file to the github issue so it is saved as a .txt, hopefully you can still load this into cobrexa... if not i can send the file directly to you as .json. So |
Ah I see, good, thanks, I'll try asap. |
OK so after some verification in slack it turns out the model is already feasible, so the gapfilling doesn't need to add anything. Solution: use I'll mark this bug as a documentation bug because it's not at all obvious from the current doc. Maybe we might print a small explanation in gapfilled_rids or so, that tells the user that the model might have been feasible already. |
closed by #662 |
A model made by removing reactions from iML1515 and then gapfilled from iML1515 to do the reaction
doesn't give a solution.
test.txt
Here is the gapfilling code:
The text was updated successfully, but these errors were encountered: