Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pretty reaction builders #581

Merged
merged 4 commits into from
Feb 9, 2022
Merged

fix pretty reaction builders #581

merged 4 commits into from
Feb 9, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Feb 9, 2022

No description provided.

@exaexa exaexa requested a review from stelmo February 9, 2022 15:25
@exaexa exaexa marked this pull request as draft February 9, 2022 15:25
@cylon-x
Copy link
Collaborator

cylon-x commented Feb 9, 2022

🟢  Commit 4db42fe is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented Feb 9, 2022

🟢  Commit 6efe3d6 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented Feb 9, 2022

🟢  Commit ed880ca is formatted properly.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #581 (ed880ca) into develop (c9240c9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #581      +/-   ##
===========================================
- Coverage    90.58%   90.56%   -0.02%     
===========================================
  Files           67       67              
  Lines         1710     1696      -14     
===========================================
- Hits          1549     1536      -13     
+ Misses         161      160       -1     
Impacted Files Coverage Δ
src/base/types/Reaction.jl 100.00% <ø> (ø)
src/base/types/Gene.jl 100.00% <100.00%> (ø)
src/base/types/JSONModel.jl 100.00% <100.00%> (ø)
src/base/types/Metabolite.jl 100.00% <100.00%> (ø)
src/base/types/StandardModel.jl 100.00% <100.00%> (ø)
src/base/types/abstract/MetabolicModel.jl 94.73% <100.00%> (+0.29%) ⬆️
src/reconstruction/Reaction.jl 100.00% <100.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e94981...ed880ca. Read the comment docs.

@exaexa exaexa marked this pull request as ready for review February 9, 2022 18:19
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much cleaner, thanks!

@exaexa exaexa merged commit e75a46a into develop Feb 9, 2022
@exaexa exaexa deleted the mk-pretty-reaction branch February 9, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants