Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

banner again! #585

Merged
merged 2 commits into from
Feb 18, 2022
Merged

banner again! #585

merged 2 commits into from
Feb 18, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Feb 18, 2022

No description provided.

@exaexa exaexa added quality improves maintainability and code clarity minor Easy fix with low priority, likely just cosmetic labels Feb 18, 2022
@exaexa exaexa added this to the v1.3 milestone Feb 18, 2022
@cylon-x
Copy link
Collaborator

cylon-x commented Feb 18, 2022

🟢  Commit b091311 is formatted properly.

stelmo
stelmo approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@codecov
Copy link

codecov bot commented Feb 18, 2022 •
edited
Loading

Codecov Report

Merging #585 (b091311) into develop (b11dc51) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #585      +/-   ##
===========================================
+ Coverage    90.47%   90.78%   +0.31%     
===========================================
  Files           67       67              
  Lines         1701     1704       +3     
===========================================
+ Hits          1539     1547       +8     
+ Misses         162      157       -5
Impacted Files Coverage Δ
src/COBREXA.jl 0.00% <ø> (ø)
src/banner.jl 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc41a5...b091311. Read the comment docs.

laurentheirendt
laurentheirendt approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@laurentheirendt laurentheirendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah 😄

@laurentheirendt laurentheirendt merged commit 14cf070 into develop Feb 18, 2022
@laurentheirendt laurentheirendt deleted the mk-ununbanner branch February 18, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stelmo stelmo stelmo approved these changes

@laurentheirendt laurentheirendt laurentheirendt approved these changes

Assignees
No one assigned
Labels
minor Easy fix with low priority, likely just cosmetic quality improves maintainability and code clarity
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@exaexa @cylon-x @stelmo @laurentheirendt