Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare a macro for inheriting the accessors for model data #588

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Mar 8, 2022

This simplifies making of the wrapper models.

@exaexa exaexa requested a review from stelmo March 8, 2022 14:37
@exaexa exaexa added this to the v1.3 milestone Mar 8, 2022
@exaexa exaexa added the quality improves maintainability and code clarity label Mar 8, 2022
@cylon-x
Copy link
Collaborator

cylon-x commented Mar 8, 2022

🟢  Commit 45fe436 is formatted properly.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #588 (45fe436) into develop (86ac6db) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #588      +/-   ##
===========================================
+ Coverage    90.78%   90.80%   +0.01%     
===========================================
  Files           67       67              
  Lines         1704     1696       -8     
===========================================
- Hits          1547     1540       -7     
+ Misses         157      156       -1     
Impacted Files Coverage Δ
src/base/macros/serialized.jl 100.00% <ø> (ø)
src/base/types/CoreModelCoupled.jl 100.00% <100.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cb05c...45fe436. Read the comment docs.

Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome

@exaexa exaexa merged commit ff8dd1b into develop Mar 16, 2022
@exaexa exaexa deleted the mk-generalize-wrappers branch March 16, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants