Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load more metadata from models #611

Merged
merged 3 commits into from
May 2, 2022
Merged

load more metadata from models #611

merged 3 commits into from
May 2, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented May 2, 2022

This should fix (or at least improve upon) #600

@exaexa exaexa requested a review from stelmo May 2, 2022 07:51
@exaexa exaexa linked an issue May 2, 2022 that may be closed by this pull request
@cylon-x
Copy link
Collaborator

cylon-x commented May 2, 2022

🟢  Commit 4bccc3b is formatted properly.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #611 (111073d) into master (535aaa4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   90.29%   90.30%           
=======================================
  Files          78       78           
  Lines        1876     1877    +1     
=======================================
+ Hits         1694     1695    +1     
  Misses        182      182           
Impacted Files Coverage Δ
src/base/types/wrappers/GeckoModel.jl 85.29% <ø> (ø)
src/base/types/Gene.jl 100.00% <100.00%> (ø)
src/base/types/MATModel.jl 91.80% <100.00%> (ø)
src/base/types/SBMLModel.jl 84.61% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f89fd...111073d. Read the comment docs.

@cylon-x
Copy link
Collaborator

cylon-x commented May 2, 2022

🟢  Commit 111073d is formatted properly.

@exaexa exaexa merged commit 2b71b8f into master May 2, 2022
@exaexa exaexa deleted the mk-load-more-metadata branch May 2, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix import of yeast GEM models
3 participants