Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mods to handle gecko model #612

Merged
merged 4 commits into from
May 15, 2022
Merged

Update mods to handle gecko model #612

merged 4 commits into from
May 15, 2022

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented May 4, 2022

Update change_constraint and change_objective to include looking into genes for the objective or variable indices. This is important, because for GeckoModel genes are variables too...

@stelmo stelmo requested a review from exaexa May 4, 2022 14:16
@stelmo stelmo added the minor Easy fix with low priority, likely just cosmetic label May 4, 2022
@cylon-x
Copy link
Collaborator

cylon-x commented May 4, 2022

🟥  Commit d779256 requires formatting!

Required formatting changes summary:

 src/analysis/modifications/generic.jl | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

@cylon-x
Copy link
Collaborator

cylon-x commented May 4, 2022

🟢  Commit fe6d682 is formatted properly.

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #612 (3cd91c2) into develop (581400d) will increase coverage by 0.17%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #612      +/-   ##
===========================================
+ Coverage    90.29%   90.46%   +0.17%     
===========================================
  Files           78       78              
  Lines         1876     1878       +2     
===========================================
+ Hits          1694     1699       +5     
+ Misses         182      179       -3     
Impacted Files Coverage Δ
src/base/types/MetabolicModel.jl 89.39% <ø> (ø)
src/base/utils/enzymes.jl 33.33% <ø> (ø)
src/base/types/wrappers/GeckoModel.jl 91.66% <83.33%> (+6.37%) ⬆️
src/base/utils/gecko.jl 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e4509...3cd91c2. Read the comment docs.

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟥  Commit c300e07 requires formatting!

Required formatting changes summary:

 src/analysis/modifications/generic.jl | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟥  Commit e861fcd requires formatting!

Required formatting changes summary:

 src/analysis/modifications/generic.jl |  6 ++----
 src/base/types/wrappers/GeckoModel.jl | 12 ++++++------
 src/base/utils/enzymes.jl             |  4 +++-
 test/analysis/gecko.jl                | 16 ++++++----------
 4 files changed, 17 insertions(+), 21 deletions(-)

@stelmo stelmo requested a review from exaexa May 15, 2022 12:54
@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit ceb6bfd is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit e70cb44 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit 1e29e08 is formatted properly.

@exaexa exaexa mentioned this pull request May 15, 2022
@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit ca95d97 is formatted properly.

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"mangeled", otherwise all ok

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit 1fd4fd8 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit 449fad1 is formatted properly.

1 similar comment
@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit 449fad1 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit ce5a8a5 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit 8959378 is formatted properly.

@cylon-x
Copy link
Collaborator

cylon-x commented May 15, 2022

🟢  Commit 3cd91c2 is formatted properly.

@stelmo stelmo merged commit 2283284 into develop May 15, 2022
@stelmo stelmo deleted the mo-gecko-mods branch May 15, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Easy fix with low priority, likely just cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants