Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: bump CompatHelper version to work with 1.8 #656

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Aug 29, 2022

Same issue and solution as with LCSB-BioCore/GigaSOM.jl#206

For CI reasons I think merging right into master will be much better here (feel free to reparent if not).

@exaexa exaexa added the quality improves maintainability and code clarity label Aug 29, 2022
@exaexa exaexa requested a review from laurentheirendt August 29, 2022 06:46
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #656 (796ade3) into master (02e0c7f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   90.42%   90.43%           
=======================================
  Files          79       79           
  Lines        1922     1923    +1     
=======================================
+ Hits         1738     1739    +1     
  Misses        184      184           
Impacted Files Coverage Δ
src/base/types/MATModel.jl 91.80% <100.00%> (ø)
src/base/types/SBMLModel.jl 84.61% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@laurentheirendt
Copy link
Contributor

shouldn't this be going into develop?

@laurentheirendt laurentheirendt changed the base branch from master to develop August 29, 2022 07:22
@exaexa
Copy link
Collaborator Author

exaexa commented Aug 30, 2022

shouldn't this be going into develop?

no, let's do master. If we merge into develop we basically postpone fix until a new release is out (which is undesirable now because we have breaking changes pending), or until we do a slighly non-systematic develop->master merge.

@exaexa exaexa changed the base branch from develop to master August 30, 2022 06:17
@exaexa exaexa changed the title bump CompatHelper version to work with 1.8 hotfix: bump CompatHelper version to work with 1.8 Aug 30, 2022
@exaexa
Copy link
Collaborator Author

exaexa commented Aug 30, 2022

Develop counterpart: #658

@laurentheirendt laurentheirendt merged commit ef9cc23 into master Aug 30, 2022
@laurentheirendt laurentheirendt deleted the mk-fix-ch branch August 30, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants