Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally add DocStringExtensions 🥳 #661

Merged
merged 12 commits into from
Aug 31, 2022
Merged

Finally add DocStringExtensions 🥳 #661

merged 12 commits into from
Aug 31, 2022

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Aug 30, 2022

This should reduce docstring out-of-sync issues!

@stelmo stelmo requested a review from exaexa August 30, 2022 20:58
@stelmo stelmo added the minor Easy fix with low priority, likely just cosmetic label Aug 30, 2022
@laurentheirendt
Copy link
Contributor

this is cool 👍🏼

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #661 (7ed54eb) into develop (5ca5200) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #661   +/-   ##
========================================
  Coverage    91.05%   91.05%           
========================================
  Files           82       82           
  Lines         2012     2012           
========================================
  Hits          1832     1832           
  Misses         180      180           
Impacted Files Coverage Δ
src/COBREXA.jl 0.00% <ø> (ø)
src/analysis/envelopes.jl 100.00% <ø> (ø)
src/analysis/flux_balance_analysis.jl 100.00% <ø> (ø)
src/analysis/flux_variability_analysis.jl 93.54% <ø> (ø)
src/analysis/gecko.jl 100.00% <ø> (ø)
src/analysis/max_min_driving_force.jl 93.33% <ø> (ø)
src/analysis/minimize_metabolic_adjustment.jl 66.66% <ø> (ø)
src/analysis/modifications/crowding.jl 100.00% <ø> (ø)
src/analysis/modifications/generic.jl 77.27% <ø> (ø)
src/analysis/modifications/knockout.jl 100.00% <ø> (ø)
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this is a good job. I've got a few questions but otherwise looks okay.

  • what about the extra operators in src/reconstruction/Reactions.jl? (could we have the typed signature and print out the intended inline usage in an example?)
  • what about code generated by macros (e.g. in src/base/macros/model_wrapper.jl), is it possible to smuggle TYPEDSIGNATURES in there?
  • is there no way to print out the const typedefs (e.g. in src/base/types/abstract/MetabolicModel.jl)

@exaexa exaexa added documentation Improvements or additions to documentation quality improves maintainability and code clarity and removed minor Easy fix with low priority, likely just cosmetic labels Aug 31, 2022
@stelmo
Copy link
Collaborator Author

stelmo commented Aug 31, 2022

Ok this is a good job. I've got a few questions but otherwise looks okay.

  • what about the extra operators in src/reconstruction/Reactions.jl? (could we have the typed signature and print out the intended inline usage in an example?)

They looked weird so I left them, but tbh, there is no good reason for leaving them. Adding them!

  • what about code generated by macros (e.g. in src/base/macros/model_wrapper.jl), is it possible to smuggle TYPEDSIGNATURES in there?

Inserting docstrings inside a macro that generates documentation seems to be an issue..

  • is there no way to print out the const typedefs (e.g. in src/base/types/abstract/MetabolicModel.jl)

I did not find anything for constants... Seems they will just be manual

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All answered I guess. Re the operators, since they are user-facing and the involved types are completely internal I guess we can do without the precise doc.

@stelmo
Copy link
Collaborator Author

stelmo commented Aug 31, 2022

/format

triggered by @stelmo on PR #661
@github-actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as 7ed54eb

@stelmo stelmo merged commit 50c5297 into develop Aug 31, 2022
@stelmo stelmo deleted the mo-dse branch August 31, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants