-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finally add DocStringExtensions 🥳 #661
Conversation
this is cool 👍🏼 |
Codecov Report
@@ Coverage Diff @@
## develop #661 +/- ##
========================================
Coverage 91.05% 91.05%
========================================
Files 82 82
Lines 2012 2012
========================================
Hits 1832 1832
Misses 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this is a good job. I've got a few questions but otherwise looks okay.
- what about the extra operators in
src/reconstruction/Reactions.jl
? (could we have the typed signature and print out the intended inline usage in an example?) - what about code generated by macros (e.g. in
src/base/macros/model_wrapper.jl
), is it possible to smuggleTYPEDSIGNATURES
in there? - is there no way to print out the
const
typedefs (e.g. insrc/base/types/abstract/MetabolicModel.jl
)
They looked weird so I left them, but tbh, there is no good reason for leaving them. Adding them!
Inserting docstrings inside a macro that generates documentation seems to be an issue..
I did not find anything for constants... Seems they will just be manual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All answered I guess. Re the operators, since they are user-facing and the involved types are completely internal I guess we can do without the precise doc.
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as 7ed54eb |
This should reduce docstring out-of-sync issues!