Add SBO terms #667
Merged
Add SBO terms #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exaexa
reviewed
Sep 3, 2022
Codecov Report
@@ Coverage Diff @@
## develop #667 +/- ##
===========================================
- Coverage 91.01% 91.00% -0.02%
===========================================
Files 81 82 +1
Lines 2004 2012 +8
===========================================
+ Hits 1824 1831 +7
- Misses 180 181 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Mirek Kratochvil <[email protected]>
|
/format |
|
✔️ Auto-formatting triggered by this comment succeeded, commited as 968804b |
|
/format |
|
✔️ Auto-formatting triggered by this comment succeeded, commited as 3855710 |
|
/format |
|
✔️ Auto-formatting triggered by this comment succeeded, commited as 52ecb09 |
|
/format |
|
✔️ Auto-formatting triggered by this comment succeeded, commited as aade33c |
|
/format |
|
✔️ Auto-formatting triggered by this comment succeeded, commited as 7db2516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBO is a systematic naming convention. We should use it to look for reactions instead of guessing based on naming. Right now just add the ontology and a few
is_xxxfunctions, but for 2.0 I propose to only using sbo terms in functions likefind_exchange_reactions. This removes the footgun of assumingfind_xxxis robust (it isn't because it depends onlooks_like)