Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch tests julia from 1.7 to 1.8 #680

Merged
merged 1 commit into from
Oct 26, 2022
Merged

switch tests julia from 1.7 to 1.8 #680

merged 1 commit into from
Oct 26, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Oct 13, 2022

1.7 is old "stable" now; this should migrate the tests to LTS (1.6) + newest Julia (1.8)

I expect trouble though 😅

@exaexa exaexa added quality improves maintainability and code clarity minor Easy fix with low priority, likely just cosmetic labels Oct 13, 2022
@exaexa exaexa added this to the v1.5 milestone Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 90.68% // Head: 90.60% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (3550c59) compared to base (8ecd4bf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #680      +/-   ##
===========================================
- Coverage    90.68%   90.60%   -0.09%     
===========================================
  Files           82       82              
  Lines         2039     2149     +110     
===========================================
+ Hits          1849     1947      +98     
- Misses         190      202      +12     
Impacted Files Coverage Δ
src/analysis/sampling/warmup_variability.jl 92.59% <0.00%> (-3.57%) ⬇️
src/analysis/parsimonious_flux_balance_analysis.jl 81.81% <0.00%> (-3.19%) ⬇️
src/base/types/SBMLModel.jl 76.19% <0.00%> (-2.56%) ⬇️
src/reconstruction/gapfill_minimum_reactions.jl 88.63% <0.00%> (-2.07%) ⬇️
src/io/show/Gene.jl 100.00% <0.00%> (ø)
src/analysis/gecko.jl 100.00% <0.00%> (ø)
src/analysis/smoment.jl 100.00% <0.00%> (ø)
src/base/utils/fluxes.jl 100.00% <0.00%> (ø)
src/analysis/envelopes.jl 100.00% <0.00%> (ø)
src/io/show/Metabolite.jl 100.00% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stelmo stelmo self-requested a review October 26, 2022 13:59
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@exaexa
Copy link
Collaborator Author

exaexa commented Oct 26, 2022

ok this is gonna be a bit of a yolo merge but c'mon it goes to develop right?

@exaexa exaexa merged commit c083ad3 into develop Oct 26, 2022
@exaexa exaexa deleted the mk-test-with-1.8 branch October 26, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Easy fix with low priority, likely just cosmetic quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants