Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove polish parameter specific to osqp #681

Merged
merged 2 commits into from
Oct 14, 2022
Merged

remove polish parameter specific to osqp #681

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d910766
remove `polish` parameter specific to osqp
exaexa Oct 14, 2022
f66abed
automatic formatting
exaexa Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/src/examples/08_pfba.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ fluxes = parsimonious_flux_balance_analysis_dict(
Clarabel.Optimizer;
modifications = [
silence, # optionally silence the optimizer (Clarabel is very verbose by default)
change_optimizer_attribute("polish", true), # tell Clarabel to invest time into improving the precision of the solution
change_constraint("R_EX_glc__D_e"; lb = -12, ub = -12), # fix glucose consumption rate
],
)
Expand All @@ -70,7 +69,6 @@ flux_vector = parsimonious_flux_balance_analysis_vec(
],
qp_modifications = [
change_optimizer(Clarabel.Optimizer), # now switch to Clarabel (Tulip wouldn't be able to finish the computation)
change_optimizer_attribute("polish", true), # get an accurate solution, see Clarabel's documentation
silence, # and make it quiet.
],
)
6 changes: 3 additions & 3 deletions docs/src/examples/13_moma.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ using Clarabel
reference_flux = flux_balance_analysis_dict(
model,
Clarabel.Optimizer;
modifications = [silence, change_optimizer_attribute("polish", true)],
modifications = [silence],
)

# As the change here, we manually knock out CYTBD reaction:
Expand All @@ -41,7 +41,7 @@ flux_summary(
changed_model,
reference_flux,
Clarabel.Optimizer;
modifications = [silence, change_optimizer_attribute("polish", true)],
modifications = [silence],
),
)

Expand All @@ -52,6 +52,6 @@ flux_summary(
flux_balance_analysis_dict(
changed_model,
Clarabel.Optimizer;
modifications = [silence, change_optimizer_attribute("polish", true)],
modifications = [silence],
),
)