Add ext option
#688
Merged
Add ext option
#688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop → master merge for v1.4.1
To decouple the type of the file content from the extension
exaexa
approved these changes
Oct 25, 2022
|
/format |
triggered by @exaexa on PR LCSB-BioCore#688
|
✔️ Auto-formatting triggered by this comment succeeded, commited as 76f6330 |
exaexa
reviewed
Oct 25, 2022
There was a problem hiding this comment.
@josePereiro I added a few cleaning commits, you'll get them in a separate PR here josePereiro#1 . Please merge the PR, we can merge this right after. Thanks again!
|
(also, tests do not work here but all seems to pass ✔️ ok ✔️ here locally, great! ) |
minor improvements for COBREXA PR 688e
|
Lovely, thanks! |
|
@josePereiro btw, let us know if you'd use having this released right now. We are not planning much other releases on the 1.4 branch but if it helps anyone I can click a small patch release (assumingly 1.4.2) :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, for some reason my raw data do not have an extension, so, I need to give it explicitly.
I just added an option to decouple the type of the file content from the extension.
Great package
Saludos