Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @add_reactions #697

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Remove @add_reactions #697

merged 4 commits into from
Nov 11, 2022

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Nov 9, 2022

This is literally the only macro construction function. It does not fit in... 🪓

@stelmo stelmo requested a review from exaexa November 9, 2022 22:54
@exaexa
Copy link
Collaborator

exaexa commented Nov 10, 2022

/format

@exaexa exaexa added the 🪓 code axing 🪓 Use this for PRs that remove code which might still be re-used later label Nov 10, 2022
@exaexa exaexa modified the milestones: v1.5, v2.0 Nov 10, 2022
triggered by @exaexa on PR #697
@github-actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as 71716a9

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic testfixing, otherwise all ok

@stelmo
Copy link
Collaborator Author

stelmo commented Nov 10, 2022

/format

@github-actions
Copy link
Contributor

☀️ Auto-formatting triggered by this comment succeeded, but the code was already formatted correctly.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 90.21% // Head: 90.12% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (b9ce5e8) compared to base (8c04d42).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #697      +/-   ##
==========================================
- Coverage   90.21%   90.12%   -0.10%     
==========================================
  Files          82       82              
  Lines        2106     2086      -20     
==========================================
- Hits         1900     1880      -20     
  Misses        206      206              
Impacted Files Coverage Δ
src/reconstruction/ObjectModel.jl 98.30% <ø> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa merged commit 2282aa7 into next Nov 11, 2022
@exaexa exaexa deleted the mo-delete-add-reactions-macro branch November 11, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪓 code axing 🪓 Use this for PRs that remove code which might still be re-used later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants