Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop → master merge for 1.4.3 #708

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Develop → master merge for 1.4.3 #708

merged 4 commits into from
Dec 7, 2022

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Dec 7, 2022

release early, release often, as usual. :D

exaexa and others added 4 commits December 6, 2022 16:41
Hashtable ordering is more random than was expected; and the unpredictability
caused bad/random results when processing large models in a distributed way.

This forcibly freezes the order for SBMLModel so that the ordering issue is
avoided completely and forever.
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 91.13% // Head: 91.30% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (2485f84) compared to base (93d7988).
Patch coverage: 97.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   91.13%   91.30%   +0.16%     
==========================================
  Files          82       82              
  Lines        2155     2208      +53     
==========================================
+ Hits         1964     2016      +52     
- Misses        191      192       +1     
Impacted Files Coverage Δ
src/analysis/flux_variability_analysis.jl 93.54% <ø> (ø)
src/base/types/SBMLModel.jl 92.75% <97.10%> (+3.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa merged commit 9b4678a into master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants