Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience macro that loads all the functions in modules #716

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Jan 7, 2023

A simple macro that just replaces

COBREXA.@using_all

with

using COBREXA.Types,
  COBREXA.Accessors,
  COBREXA.Analysis,
  COBREXA.Analysis.Modifications,
  COBREXA.Reconstruction,
  COBREXA.Reconstruction.Modifications,
  COBREXA.Utils,
  COBREXA.IO,
  COBREXA.Solver

when called.

@stelmo stelmo requested a review from exaexa January 7, 2023 16:06
@stelmo
Copy link
Collaborator Author

stelmo commented Jan 7, 2023

/format

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

✔️ Auto-formatting triggered by this comment succeeded, commited as 37e02f8

github-actions bot pushed a commit that referenced this pull request Jan 7, 2023
triggered by @stelmo on PR #716
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Base: 89.58% // Head: 89.53% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (ae5bdf7) compared to base (504d4fb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #716      +/-   ##
==========================================
- Coverage   89.58%   89.53%   -0.05%     
==========================================
  Files          80       81       +1     
  Lines        1949     1950       +1     
==========================================
  Hits         1746     1746              
- Misses        203      204       +1     
Impacted Files Coverage Δ
src/moduletools.jl 0.00% <0.00%> (ø)
src/reconstruction/pipes/enzymes.jl 100.00% <ø> (ø)
src/reconstruction/pipes/generic.jl 40.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa
Copy link
Collaborator

exaexa commented Jan 7, 2023

I'll have a look into module re-exports, sec

@exaexa
Copy link
Collaborator

exaexa commented Jan 7, 2023

Ha, this could help: https://github.com/simonster/Reexport.jl/blob/master/src/Reexport.jl
(we can simplify and intern the macro to avoid unnecessary dep)

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm redoing this to an everymodule; macros here would be too wild

@exaexa
Copy link
Collaborator

exaexa commented Jan 16, 2023

@stelmo I got to the point where I have

WARNING: ignoring conflicting import of Reconstruction.Modifications into Everything

what do? :D

@stelmo
Copy link
Collaborator Author

stelmo commented Jan 16, 2023

That looks great!!

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is good now, let's merge so the rest of next can enjoy

@exaexa exaexa merged commit 2b39de5 into next Jan 23, 2023
@exaexa exaexa deleted the mo-load-all branch January 23, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants