Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessors for enzyme associated data #724

Merged
merged 9 commits into from
Jan 13, 2023
Merged

Add accessors for enzyme associated data #724

merged 9 commits into from
Jan 13, 2023

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Jan 10, 2023

No description provided.

@stelmo stelmo added the do not merge When a PR is labelled as such, do not merge label Jan 10, 2023
@stelmo
Copy link
Collaborator Author

stelmo commented Jan 10, 2023

@exaexa could you look at the accessors I added? I will fix the tests soon

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay, some structural cleaning needed

@stelmo stelmo force-pushed the mo-enzyme-accessors branch from dcbb253 to 13488c3 Compare January 11, 2023 12:11
@stelmo
Copy link
Collaborator Author

stelmo commented Jan 11, 2023

/format

@github-actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as 94e7218

github-actions bot pushed a commit that referenced this pull request Jan 11, 2023
triggered by @stelmo on PR #724
@stelmo
Copy link
Collaborator Author

stelmo commented Jan 11, 2023

/format

@github-actions
Copy link
Contributor

☀️ Auto-formatting triggered by this comment succeeded, but the code was already formatted correctly.

stelmo added a commit that referenced this pull request Jan 11, 2023
triggered by @stelmo on PR #724
@stelmo stelmo force-pushed the mo-enzyme-accessors branch from 5d39dfb to 2db86bc Compare January 11, 2023 12:48
triggered by @stelmo on PR #724
@stelmo stelmo force-pushed the mo-enzyme-accessors branch from 2db86bc to a0d2fe2 Compare January 11, 2023 12:49
@stelmo stelmo requested a review from exaexa January 11, 2023 13:05
@stelmo stelmo removed the do not merge When a PR is labelled as such, do not merge label Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 89.61% // Head: 89.41% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (59b8567) compared to base (e804d1a).
Patch coverage: 85.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #724      +/-   ##
==========================================
- Coverage   89.61%   89.41%   -0.20%     
==========================================
  Files          81       81              
  Lines        1916     1918       +2     
==========================================
- Hits         1717     1715       -2     
- Misses        199      203       +4     
Impacted Files Coverage Δ
src/types/Gene.jl 100.00% <ø> (ø)
src/types/accessors/AbstractMetabolicModel.jl 81.15% <0.00%> (-5.00%) ⬇️
src/utils/enzyme_constrained.jl 25.00% <ø> (-20.46%) ⬇️
src/reconstruction/enzyme_constrained.jl 100.00% <100.00%> (ø)
...rc/reconstruction/simplified_enzyme_constrained.jl 100.00% <100.00%> (ø)
src/types/GeneAssociations.jl 100.00% <100.00%> (ø)
src/types/accessors/ModelWrapper.jl 66.66% <100.00%> (ø)
src/types/models/ObjectModel.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, FFTM

@stelmo stelmo merged commit a37a6ce into next Jan 13, 2023
@stelmo stelmo deleted the mo-enzyme-accessors branch January 13, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants