Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete print_banner() from the SIF container #727

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jan 17, 2023

(now it prints an error, thanks @fjconejero for spotting)

(now it prints an error, thanks @fjconejero for spotting)
@exaexa exaexa requested a review from stelmo January 17, 2023 14:33
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 91.30% // Head: 91.30% // No change to project coverage 👍

Coverage data is based on head (615a6f5) compared to base (2485f84).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          82       82           
  Lines        2208     2208           
=======================================
  Hits         2016     2016           
  Misses        192      192           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa merged commit a69d353 into master Jan 19, 2023
@exaexa exaexa deleted the mk-remove-obsolete-print-banner branch January 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants