Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an actual GPA/GRR to DNF parser #731

Merged
merged 8 commits into from
Jan 27, 2023
Merged

add an actual GPA/GRR to DNF parser #731

merged 8 commits into from
Jan 27, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jan 27, 2023

This should fix #711 for good.

@exaexa exaexa requested a review from stelmo January 27, 2023 13:57
@exaexa exaexa added quality improves maintainability and code clarity feature New feature/functionality labels Jan 27, 2023
@exaexa exaexa added this to the v1.5 milestone Jan 27, 2023
@exaexa exaexa force-pushed the mk-actual-grr-parser branch from 5f7d39d to 271bee3 Compare January 27, 2023 13:59
@exaexa exaexa force-pushed the mk-actual-grr-parser branch from 271bee3 to f3f6dc4 Compare January 27, 2023 14:11
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 91.30% // Head: 91.30% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (478c03a) compared to base (d54d60e).
Patch coverage: 96.77% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #731      +/-   ##
===========================================
- Coverage    91.30%   91.30%   -0.01%     
===========================================
  Files           82       82              
  Lines         2208     2184      -24     
===========================================
- Hits          2016     1994      -22     
+ Misses         192      190       -2     
Impacted Files Coverage Δ
src/COBREXA.jl 0.00% <ø> (ø)
src/base/utils/gene_associations.jl 97.14% <96.77%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa force-pushed the mk-actual-grr-parser branch from 8e9c0f9 to 478c03a Compare January 27, 2023 19:36
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 👍

@exaexa exaexa merged commit ac27ca5 into develop Jan 27, 2023
@exaexa exaexa deleted the mk-actual-grr-parser branch January 27, 2023 21:07
@exaexa exaexa mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature/functionality quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants