Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GRA compat once more (and hopefully the last time) #734

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Jan 28, 2023

No description provided.

> Originally, Seth was a sky god, lord of the desert, master of storms,
> disorder, and warfare -- in general, a trickster. Set embodied the necessary
> and creative element of violence and disorder within the ordered world.
@exaexa exaexa requested a review from stelmo January 28, 2023 19:37
Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 91.25% // Head: 91.34% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (dcc348d) compared to base (6bb6a86).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #734      +/-   ##
===========================================
+ Coverage    91.25%   91.34%   +0.09%     
===========================================
  Files           82       82              
  Lines         2196     2196              
===========================================
+ Hits          2004     2006       +2     
+ Misses         192      190       -2     
Impacted Files Coverage Δ
src/base/types/StandardModel.jl 100.00% <ø> (ø)
src/base/utils/gene_associations.jl 97.87% <100.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa exaexa merged commit ab0474d into develop Jan 28, 2023
@exaexa exaexa deleted the mk-gra-fix-compat branch January 28, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants