extensible variable semantics #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exaexa
changed the title
exaexa
force-pushed
the
mk-extensible-variables
branch
from
6e8d79d to
c00e228
Compare
Codecov ReportBase: 90.33% // Head: 89.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #735 +/- ##
==========================================
- Coverage 90.33% 89.38% -0.96%
==========================================
Files 81 82 +1
Lines 2008 2053 +45
==========================================
+ Hits 1814 1835 +21
- Misses 194 218 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@stelmo there are some TODOs before I can merge this, but the API for variables is final. I'll do the constraint APIs in a separate PR. |
exaexa
force-pushed
the
mk-extensible-variables
branch
from
1d840d2 to
efb6ed8
Compare
exaexa
force-pushed
the
mk-extensible-variables
branch
from
164008c to
17958d0
Compare
exaexa
force-pushed
the
mk-extensible-variables
branch
from
76332a2 to
add7fee
Compare
exaexa
force-pushed
the
mk-extensible-variables
branch
from
add7fee to
4e2478a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really working yet, but this should clear the current mess in variables vs. reactions vs. fluxes vs. enzymes vs. mass groups vs. whatnot.