Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove and clean up GeneAssociations alias #753

Merged
merged 1 commit into from
Feb 15, 2023
Merged

remove and clean up GeneAssociations alias #753

merged 1 commit into from
Feb 15, 2023

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Feb 15, 2023

  • it was too similar to GeneAssociationsDNF
  • Vector{Isozyme} actually explains the contents very well, and no complexity is hidden

- it was too similar to GeneAssociationsDNF
- Vector{Isozyme} actually explains the contents very well, and no complexity
  is hidden
@exaexa exaexa requested a review from stelmo February 15, 2023 08:57
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 88.44% // Head: 88.44% // No change to project coverage 👍

Coverage data is based on head (9f57b0b) compared to base (8484eb3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #753   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files          88       88           
  Lines        2095     2095           
=======================================
  Hits         1853     1853           
  Misses        242      242           
Impacted Files Coverage Δ
src/types/GeneAssociations.jl 100.00% <ø> (ø)
src/types/Reaction.jl 100.00% <ø> (ø)
src/types/misc/gene_associations.jl 95.34% <0.00%> (ø)
src/types/models/MatrixModel.jl 96.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

@exaexa exaexa merged commit b486c6d into next Feb 15, 2023
@exaexa exaexa deleted the mk-ga-naming branch February 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants