-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary docstrings #754
Conversation
16d4966
to
b7e228c
Compare
Codecov ReportBase: 88.49% // Head: 88.49% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## next #754 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 88 88
Lines 2103 2103
=======================================
Hits 1861 1861
Misses 242 242
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Not sure if this is better or worse. Also not sure why |
All docstrings removed, but where appropriate I added information to the model constructors to make it clearer where the accessors might surprise people |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a good 🪓
Some docstrings are not necessary (especially generic inherited methods). Remove them