Make kwargs for convenience enzyme constrained consistent #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why the tests did not run |
|
no idea why this is giving an error [ Info: Precompiling COBREXA [babc4406-5200-4a30-9033-bf5ae714c842]
WARNING: Method definition make_enzyme_constrained_model(COBREXA.Types.AbstractMetabolicModel) in module Reconstruction at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:39 overwritten at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:179.
** incremental compilation may be fatally broken for this module **
WARNING: Method definition kwcall(Any, typeof(COBREXA.Reconstruction.make_enzyme_constrained_model), COBREXA.Types.AbstractMetabolicModel) in module Reconstruction at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:39 overwritten at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:179.
** incremental compilation may be fatally broken for this module **
┌ Warning: Replacing docs for `COBREXA.Reconstruction.make_enzyme_constrained_model :: Tuple{COBREXA.Types.AbstractMetabolicModel}` in module `COBREXA.Reconstruction`
└ @ Base.Docs docs\Docs.jl:243 |
|
Ahhh, you can't dispatch on kwargs! |
|
Sigh, this means that this PR won't work 😢 |
stelmo
force-pushed
the
mo-homogenize-kwargs-enzyme-constrained
branch
from
98f2891 to
afcb691
Compare
|
Fixed this! |
|
also changed the |
stelmo
added
do not merge
stelmo
force-pushed
the
mo-homogenize-kwargs-enzyme-constrained
branch
from
8a62d49 to
dbc5282
Compare
exaexa
requested changes
Feb 18, 2023
Codecov ReportBase: 88.19% // Head: 88.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #759 +/- ##
==========================================
+ Coverage 88.19% 88.22% +0.02%
==========================================
Files 88 88
Lines 2110 2114 +4
==========================================
+ Hits 1861 1865 +4
Misses 249 249
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
stelmo
force-pushed
the
mo-homogenize-kwargs-enzyme-constrained
branch
2 times, most recently
from
f8b03cf to
e7d7798
Compare
|
/format |
|
✔️ Auto-formatting triggered by this comment succeeded, commited as a3c4fc7 |
stelmo
force-pushed
the
mo-homogenize-kwargs-enzyme-constrained
branch
from
e6c3d2b to
f72d662
Compare
stelmo
force-pushed
the
mo-homogenize-kwargs-enzyme-constrained
branch
from
f72d662 to
3edaa78
Compare
exaexa
requested changes
Feb 18, 2023
exaexa
requested changes
Feb 18, 2023
stelmo
force-pushed
the
mo-homogenize-kwargs-enzyme-constrained
branch
from
09d9f45 to
68f46f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
total_enzyme_capacityis used in the simplified enzyme constrained model