-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and extend reconstruction functions and pipes for objectmodel #762
Conversation
No idea why this is failing... |
This turned into a big housekeeping session |
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as dba3ae1 |
dba3ae1
to
1d719f8
Compare
@exaexa the formatter causes this PR to break because it tries to split lines incorrectly. @io_log @warn "Automatically converting $(typeof(model)) to JSONModel for saving, information may be lost." After formatting (error): @io_log
@warn "Automatically converting $(typeof(model)) to JSONModel for saving, information may be lost." |
Codecov ReportBase: 88.31% // Head: 88.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #762 +/- ##
==========================================
+ Coverage 88.31% 88.37% +0.06%
==========================================
Files 89 90 +1
Lines 2113 2236 +123
==========================================
+ Hits 1866 1976 +110
- Misses 247 260 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
7f06c1d
to
6073c05
Compare
2abc80c
to
56c73c8
Compare
@exaexa I think this should be ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly okay, small tech changes needed
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as fbc5352 |
/format |
☀️ Auto-formatting triggered by this comment succeeded, but the code was already formatted correctly. |
4056d34
to
0670031
Compare
adds non-inplace
change_objective
as well as pipefixes
change_bound
to copy all fieldsadds
change_gene_product_bound
in-place, non-inplace, as well as pipesAlso change modifications to have the prefix
modify_
instead ofchange
. This was to prevent name space issues.Reconstruction functions have
add_
,remove_
andchange_
prefixes now.