Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated topic configuration data types #143

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

gokerakc
Copy link
Contributor

About the PR

The following properties need to be updated as long:

  • retention.ms

  • retention.bytes

  • delete.retention.ms

If you need further details about the configs you can check this documentation page: https://kafka.apache.org/documentation/#topicconfigs_retention.bytes

Changelog

  • Updated data types from integer to long

Note

I have also created a PR in the asyncapi/bindings repo here: asyncapi/bindings#242

@gokerakc
Copy link
Contributor Author

@VisualBean I think we can merge these changes in without waiting for the asyncapi/bindings PR but if you want we can wait for it.

@VisualBean
Copy link
Contributor

Good change 👍

Copy link
Contributor

@VisualBean VisualBean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although technically a breaking change, I think we are fine.

@VisualBean VisualBean merged commit eace86d into LEGO:main Feb 14, 2024
6 checks passed
@gokerakc gokerakc deleted the fix_UpdateDataTypes branch February 14, 2024 10:28
@gokerakc
Copy link
Contributor Author

Hey @VisualBean, I think we have a problem with publishing the new version of the Nuget packages. Please check the following error:

https://github.com/LEGO/AsyncAPI.NET/actions/runs/7899622069/job/21559489948#step:5:8

It tries to use the same beta version that was published yesterday.

@VisualBean
Copy link
Contributor

Hey @VisualBean, I think we have a problem with publishing the new version of the Nuget packages. Please check the following error:

https://github.com/LEGO/AsyncAPI.NET/actions/runs/7899622069/job/21559489948#step:5:8

It tries to use the same beta version that was published yesterday.

I'll take a look

@VisualBean
Copy link
Contributor

made a full release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants