Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window still takes up space after close to system tray #6

Closed
crosstyan opened this issue Aug 15, 2021 · 1 comment
Closed

Window still takes up space after close to system tray #6

crosstyan opened this issue Aug 15, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@crosstyan
Copy link

Some chat app and music app will have a option to close to system tray.

But window still takes up space after close to system tray, but komorebi works well when minimizing window.

TakeSpace

Tested apps:

  • Discord
  • Telegram
@LGUG2Z LGUG2Z added bug Something isn't working good first issue labels Aug 16, 2021
@LGUG2Z LGUG2Z self-assigned this Aug 16, 2021
@LGUG2Z LGUG2Z added enhancement New feature or request and removed bug Something isn't working labels Aug 16, 2021
@LGUG2Z LGUG2Z closed this as completed in b2ab893 Aug 16, 2021
@LGUG2Z
Copy link
Owner

LGUG2Z commented Aug 16, 2021

@crosstyan You can now add this to your config file for those two applications, and any other applications that close to the system tray. 🎉

alex-ds13 added a commit to alex-ds13/komorebi that referenced this issue Jan 21, 2025
# This is a combination of 8 commits.
# This is the 1st commit message:

fix(bar): add simplified config for bar

This commit creates a few new config options for the bar that should
make it a lot simpler for new users to configure the bar.
- Remove the need for `position`: if a position is given the bar will
  still use it with priority over the new config. Instead of position
  you can now use the following:
  - `height`: defines the height of the bar (50 by default)
  - `horizontal_margin`: defines the left and right offset of the bar, it
  is the same as setting a `position.start.x` and then remove the same
  amount on `position.end.x`.
  - `vertical_margin`: defines the top and bottom offset of the bar, it is
  the same as setting a `position.start.y` and then add a correct amount
  on the `work_area_offset`.
- Remove the need for `frame`: some new configs were added that take
  priority over the old `frame`. These are:
  - `horizontal_padding`: defines the left and right padding of the bar.
    Similar to `frame.inner_margin.x`.
  - `vertical_padding`: defines the top and bottom padding of the bar.
    Similar to `frame.inner_margin.y`.
- Remove the need for `work_area_offset`: if a `work_area_offset` is
  given then it will take priority, if not, then it will calculate the
  necessary `work_area_offset` using the bar height, position and
  horizontal and vertical margins.

# This is the commit message LGUG2Z#2:

feat(bar): set margin/padding as one or two values

This commit changes the `horizontal_margin`, `vertical_margin`,
`horizontal_padding` and `vertical_padding` to now take a
`SpacingAxisConfig` which can take a single value or two values.
For example, you can set the vertical margin of the bar to add some
spacing above and below like this:
```json
"vertical_margin": 10
```
Which will add a spacing of 10 above and below the bar. Or you can set
it like this:
```json
"vertical_margin": [10, 0]
```
Which will add a spacing of 10 above the bar but no spacing below. You
can even set something like this:
```json
"vertical_margin": [0, -10]
```
To make no spacing above and a negative spacing below to make it so the
tiled windows show right next to the bar. This will basically be
removing the workspace and container padding between the tiled windows
and the bar.

# This is the commit message LGUG2Z#3:

fix(bar): use a right_to_left layout on right side

This commit changes the right area with the right widgets to have a
different layout that is still right_to_left as previously but behaves
much better in regards to its height.

# This is the commit message LGUG2Z#4:

fix(bar): use default bar height

When there is no `work_area_offset` and no `height` on the config it was
using the `BAR_HEIGHT` as default, however the automatica
work_area_offset calculation wasn't being done properly. Now it is!

# This is the commit message LGUG2Z#5:

feat(bar): monitor can be `MonitorConfig` or index

This commit allows the `"monitor":` config to take a `MonitorConfig`
object like it used to or simply a number (index).

# This is the commit message LGUG2Z#6:

docs(schema): update all json schemas

# This is the commit message LGUG2Z#7:

fix(bar): update example bar config

# This is the commit message LGUG2Z#8:

fix(bar): correct work_area_offset on secondary monitors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants