Ignore Error Message if Not IPython #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
added
status-ready-for-review
cscully-allison
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
This looks good to me. The 'not isinstance()' check leading into the print can be a little confusing as we are printing in the positive case that there is a Python object. However I acknowledge that this is the best compact 1-line way to write it and only takes a second to understand.
ilumsden
requested changes
Sep 3, 2024
ilumsden
added
status-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#127 introduced a bug where the error message
will always print if the
IPythonmodule is installed, even when running outside ofIPython, such as when running hatchet in a terminal.This PR fixes the bug by not printing the error message if IPython is not registered.