Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node ordering #94

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Node ordering #94

merged 4 commits into from
Jul 12, 2023

Conversation

dyokelson
Copy link
Collaborator

@dyokelson dyokelson commented Jun 30, 2023

Updates to take into account the node order column in caliper

@dyokelson dyokelson marked this pull request as draft June 30, 2023 22:44
@slabasan
Copy link
Collaborator

slabasan commented Jul 1, 2023

@dyokelson Would you be able to pull out the python2 changes from this PR into a new one? Would be good to merge in just the python2 changes first, then I'm hoping the other PRs will start passing again. Let me know if I can help.

Updates to take into account the node ordering

remove python 2.7: no longer supported github ci

reverting to how I assigned _hatchet_nid earlier

switch back to ubuntu-20.04

ran python black formatting
@dyokelson
Copy link
Collaborator Author

Rebased after the CI fix and python 2 deprecation merge. This contains functionality for ordering hatchet graphs and dataframes by the optional "Node order" column in caliper.

@dyokelson dyokelson added enhancement area-readers Issues and PRs involving Hatchet's data readers priority-normal Normal priority issues and PRs type-feature Requests for new features or PRs which implement new features status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Jul 10, 2023
@dyokelson dyokelson requested a review from slabasan July 10, 2023 21:20
@dyokelson dyokelson marked this pull request as ready for review July 10, 2023 21:36
@slabasan slabasan merged commit e9e06df into LLNL:develop Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-readers Issues and PRs involving Hatchet's data readers priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants