Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter_profile to Tutorial #47

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

michaelmckinsey1
Copy link
Collaborator

No description provided.

Michael Richard Mckinsey added 2 commits July 2, 2024 11:08
@michaelmckinsey1 michaelmckinsey1 changed the title Add filter_profile doc Add filter_profile to Tutorial Jul 2, 2024
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jul 8, 2024
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text changes look good, but I'm not sure what the first commit is doing. As far as I can tell, all it does is change the metadata in the 01_thicket_tutorial.ipynb. @michaelmckinsey1 can you explain what that commit is doing?

@michaelmckinsey1
Copy link
Collaborator Author

The text changes look good, but I'm not sure what the first commit is doing. As far as I can tell, all it does is change the metadata in the 01_thicket_tutorial.ipynb. @michaelmckinsey1 can you explain what that commit is doing?

1d9f629 adds a new section in 01_thicket_tutorial.ipynb for the filter_profile function with 4 new cells. I'm not sure what changes you are looking at.

@ilumsden
Copy link
Collaborator

The text changes look good, but I'm not sure what the first commit is doing. As far as I can tell, all it does is change the metadata in the 01_thicket_tutorial.ipynb. @michaelmckinsey1 can you explain what that commit is doing?

1d9f629 adds a new section in 01_thicket_tutorial.ipynb for the filter_profile function with 4 new cells. I'm not sure what changes you are looking at.

For me, that commit just shows a yellow dropdown line saying "Notebook metadata changed". When I click on the dropdown, it just shows that you've run with a newer version of Python. GitHub shows no other changes

"id": "3fe4f805",
"metadata": {},
"source": [
"### 4.i Profiles\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is section 4.i? I see that you're using 4.1, 4.2, .. going forward.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to distinguish the profiles section from the other sections, since we historically haven't had users interface with the profile objects. But they could just be 4.1 Profiles, 4.2 Performance Data, ...

Copy link
Collaborator

@slabasan slabasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and wondering if @ilumsden's comment was resolved?

@michaelmckinsey1
Copy link
Collaborator Author

One question and wondering if @ilumsden's comment was resolved?

I think his github was glitched. @slabasan Do you see changes to notebook content, +49 −2 lines of code changes? It seems like he was saying he only saw a couple of lines of changes without notebook content changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants