-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter_profile to Tutorial #47
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text changes look good, but I'm not sure what the first commit is doing. As far as I can tell, all it does is change the metadata in the 01_thicket_tutorial.ipynb
. @michaelmckinsey1 can you explain what that commit is doing?
1d9f629 adds a new section in |
For me, that commit just shows a yellow dropdown line saying "Notebook metadata changed". When I click on the dropdown, it just shows that you've run with a newer version of Python. GitHub shows no other changes |
"id": "3fe4f805", | ||
"metadata": {}, | ||
"source": [ | ||
"### 4.i Profiles\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is section 4.i? I see that you're using 4.1, 4.2, .. going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to distinguish the profiles section from the other sections, since we historically haven't had users interface with the profile objects. But they could just be 4.1 Profiles
, 4.2 Performance Data
, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and wondering if @ilumsden's comment was resolved?
No description provided.