Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spack bootstrap now to find clingo #122

Merged
merged 11 commits into from
Dec 20, 2024

Conversation

chapman39
Copy link
Collaborator

@chapman39 chapman39 commented Aug 30, 2023

Use spack commands to setup clingo rather than relying on pip.

  • make clingo default and only option (Fixes Eventually remove setting concretizer:clingo #134)
    • the other concretizer option will be removed in future spack versions and has been removed since v0.23)
  • bootstrap clingo (Fixes Move to spack bootstrap now #118)
  • fix spack_setup_clingo option, i realized this was always broken.
  • update .ci package recipes to import spack.package rather than just spack, as it's required in recent spack versions

@chapman39 chapman39 self-assigned this Aug 30, 2023
@chapman39
Copy link
Collaborator Author

chapman39 commented Aug 30, 2023

Should clingo be the default concretizer in uberenv?

edit: yes

@chapman39 chapman39 changed the title WIP: Use spack bootstrap now to find clingo Use spack bootstrap now to find clingo Aug 30, 2023
@chapman39
Copy link
Collaborator Author

[exe: /home/runner/work/uberenv/uberenv/.ci/test-project/uberenv_libs/spack/bin/spack bootstrap now]
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.4/build_cache/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-idkenmhnscjlu5gjqhpcqa4h7o2a7aow.spec.json
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.4/build_cache/linux-centos7-x86_[64](https://github.com/LLNL/uberenv/actions/runs/6030953662/job/16363766980?pr=122#step:4:65)/gcc-10.2.1/clingo-bootstrap-spack/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-idkenmhnscjlu5gjqhpcqa4h7o2a7aow.spack
==> Installing "clingo-bootstrap@=spack%gcc@=10.2.1~docs~ipo+python+static_libstdcpp build_type=Release arch=linux-centos7-x86_64" from a buildcache
[exe: /home/runner/work/uberenv/uberenv/.ci/test-project/uberenv_libs/spack/bin/spack bootstrap status]
Spack v0.21.0.dev0 - [email protected]

[PASS] Core Functionalities

[PASS] Binary packages

https://github.com/LLNL/uberenv/actions/runs/6030953662/job/16363766980?pr=122#step:4:66

@chapman39 chapman39 marked this pull request as draft December 18, 2024 20:09
@chapman39 chapman39 marked this pull request as ready for review December 20, 2024 19:36
Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@white238 white238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chapman39 !

@chapman39 chapman39 merged commit 44ab4ca into main Dec 20, 2024
8 checks passed
@chapman39 chapman39 deleted the feature/chapman39/find_clingo_thru_spack branch December 20, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventually remove setting concretizer:clingo Move to spack bootstrap now
3 participants