Avoid importing unused cpython array for compatibility with pypy #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We keep the changelog locally. If you write a short note, I will include it with the next release. Thanks for identifying this issue. I will merge once the tests pass. |
|
I think the title says it all. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #109 +/- ##
===========================================
- Coverage 94.40% 94.40% -0.01%
===========================================
Files 263 263
Lines 12683 12682 -1
===========================================
- Hits 11973 11972 -1
Misses 710 710
Continue to review full report at Codecov.
|
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you have a changelog you want me to add a note in?
A good explanation as to why this is important
h5py/h5py#1514