Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Track Recording Stage One #5990

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from

Merge remote-tracking branch 'origin/master' into feature/recording-s…

d586ea2
Select commit
Loading
Failed to load commit list.
Draft

Sample Track Recording Stage One #5990

Merge remote-tracking branch 'origin/master' into feature/recording-s…
d586ea2
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor succeeded Aug 11, 2024 in 1s

15 issues fixed. 7 issues found.

Annotations

Check notice on line 51 in include/PatternTrack.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/PatternTrack.h#L51

"virtual" is redundant since function is already declared as "override" (readability/inheritance)

Check notice on line 46 in include/PatternTrack.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/PatternTrack.h#L46

"virtual" is redundant since function is already declared as "override" (readability/inheritance)

Check notice on line 436 in src/core/InstrumentFunctions.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/InstrumentFunctions.cpp#L436

Consider using rand_r(...) instead of rand(...) for improved thread safety. (runtime/threadsafe_fn)

Check notice on line 211 in src/core/Sample.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/Sample.cpp#L173-L211

Complex Method

Check notice on line 420 in src/core/InstrumentFunctions.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/InstrumentFunctions.cpp#L420

Consider using rand_r(...) instead of rand(...) for improved thread safety. (runtime/threadsafe_fn)

Check notice on line 465 in src/core/InstrumentFunctions.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/InstrumentFunctions.cpp#L465

Consider using rand_r(...) instead of rand(...) for improved thread safety. (runtime/threadsafe_fn)

Check notice on line 166 in include/Oscillator.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

include/Oscillator.h#L166

Consider using rand_r(...) instead of rand(...) for improved thread safety. (runtime/threadsafe_fn)