Skip to content

Commit

Permalink
Merge pull request #92 from Laguna1989/feature/BuilderFromSoundDataIn…
Browse files Browse the repository at this point in the history
…terface

Take Interface, not the concrete class
  • Loading branch information
Laguna1989 authored Dec 25, 2023
2 parents 5da288a + 6c91dc8 commit 21f453a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion impl/oalpp/sound_data/sound_data_builder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ oalpp::SoundDataBuilder& oalpp::SoundDataBuilder::fromFile(std::string const& fi
return *this;
}

oalpp::SoundDataBuilder& oalpp::SoundDataBuilder::fromExistingSoundData(SoundData const& data)
oalpp::SoundDataBuilder& oalpp::SoundDataBuilder::fromExistingSoundData(SoundDataInterface const& data)
{
m_data = data.getSamples();
m_sampleRate = data.getSampleRate();
Expand Down
2 changes: 1 addition & 1 deletion impl/oalpp/sound_data/sound_data_builder.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class SoundDataBuilder {
/// Load SoundData content from an already existing SoundData instance
/// \param data SoundData to copy from
/// \return SoundDataBuilder object (fluent interface)
[[nodiscard]] SoundDataBuilder& fromExistingSoundData(SoundData const& data);
[[nodiscard]] SoundDataBuilder& fromExistingSoundData(SoundDataInterface const& data);

/// Apply an effect to the SoundData
/// \param effect effect to be applied
Expand Down

0 comments on commit 21f453a

Please sign in to comment.