Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions deprecation #5183

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Github Actions deprecation #5183

merged 2 commits into from
Dec 18, 2020

Conversation

InCogNiTo124
Copy link
Contributor

What does this PR do?

A call from github actions is deprecated and it should be replaced with a newer version

Fixes #5153

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • [] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@InCogNiTo124
Copy link
Contributor Author

@Borda I replaced the ::set-env with ::set-output but I kept the rest of the arguments. I am not sure if I was supposed to change the arguments as well as per the example you've references in the issue

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #5183 (43d323f) into master (16e819e) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5183    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         134     134            
  Lines        9928    9928            
=======================================
+ Hits         8861    9242   +381     
+ Misses       1067     686   -381     

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update also the usage as steps.get_version.outputs.RELEASE_VERSION

@Borda Borda self-assigned this Dec 18, 2020
@Borda Borda added this to the 1.1.x milestone Dec 18, 2020
@Borda Borda added priority: 1 Medium priority task ci Continuous Integration labels Dec 18, 2020
@Borda Borda added the ready PRs ready to be merged label Dec 18, 2020
@SeanNaren SeanNaren self-requested a review December 18, 2020 21:12
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @InCogNiTo124!!

@Borda Borda merged commit 5d2fa98 into Lightning-AI:master Dec 18, 2020
@InCogNiTo124 InCogNiTo124 deleted the github-action-deprecation branch December 18, 2020 23:21
Borda added a commit that referenced this pull request Dec 23, 2020
* Fix deprecation call

* fix

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Dec 29, 2020
* Fix deprecation call

* fix

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Jan 4, 2021
* Fix deprecation call

* fix

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Jan 4, 2021
* Fix deprecation call

* fix

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Jan 5, 2021
* Fix deprecation call

* fix

Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Fix GitHub Action Release Deprecation
4 participants