Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix typo in Trainer.test() #5226

Merged
merged 3 commits into from
Dec 24, 2020
Merged

[Docs] Fix typo in Trainer.test() #5226

merged 3 commits into from
Dec 24, 2020

Conversation

JamesTrick
Copy link
Contributor

What does this PR do?

This is an extremely small PR fixing a typo in the Trainer.test() docs example.

Currently, it reads:

Trainer.test(test_dataloader=test_dataloader)

It's currently missing the 's', it should read:

Trainer.test(test_dataloaders=test_dataloader)

Fixes: No issue found/small typo.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #5226 (1320429) into master (5651c9c) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5226   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         134     134           
  Lines        9945    9942    -3     
======================================
- Hits         9259    9256    -3     
  Misses        686     686           

@Borda Borda added the docs Documentation related label Dec 21, 2020
@Borda Borda added this to the 1.1.x milestone Dec 21, 2020
@Borda Borda added the ready PRs ready to be merged label Dec 21, 2020
@Borda Borda enabled auto-merge (squash) December 23, 2020 16:18
@Borda Borda merged commit 1d53307 into Lightning-AI:master Dec 24, 2020
Borda pushed a commit that referenced this pull request Jan 6, 2021
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 1d53307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants