Tighten up mypy config #5237
Merged
Tighten up mypy config #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhdu
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5237 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9932 9932
======================================
Hits 9246 9246
Misses 686 686 |
Borda
approved these changes
Dec 22, 2020
s-rog
approved these changes
Dec 23, 2020
rohitgr7
approved these changes
Dec 23, 2020
Borda
pushed a commit
that referenced
this pull request
Dec 23, 2020
Borda
pushed a commit
that referenced
this pull request
Dec 29, 2020
Borda
pushed a commit
that referenced
this pull request
Jan 4, 2021
Borda
pushed a commit
that referenced
this pull request
Jan 4, 2021
Borda
pushed a commit
that referenced
this pull request
Jan 5, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the mypy config with some helpful flags:
show_error_codes-- this makes it easier to# type: ignore[error-code], which limits the blast radius of any given ignore commentwarn_redundant_castsandwarn_unused_ignoresnotify you when type work-arounds are no longer neededwarn_unused_configs-- this helps catch potential typos in the mypy configuration.