-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existence check for hparams now uses underlying filesystem #5250
Merged
awaelchli
merged 6 commits into
Lightning-AI:master
from
kandluis:bugfix/5249_hparams_existence_check
Jan 5, 2021
Merged
Existence check for hparams now uses underlying filesystem #5250
awaelchli
merged 6 commits into
Lightning-AI:master
from
kandluis:bugfix/5249_hparams_existence_check
Jan 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5250 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9976 9976
======================================
Hits 9294 9294
Misses 682 682 |
awaelchli
approved these changes
Dec 24, 2020
s-rog
approved these changes
Dec 25, 2020
rohitgr7
approved these changes
Dec 26, 2020
Borda
approved these changes
Jan 5, 2021
@awaelchli pls check is it 1.2 or 1.1.x? the description says 1.2 but the target is master… |
Borda
pushed a commit
that referenced
this pull request
Jan 6, 2021
Co-authored-by: Rohit Gupta <[email protected]> (cherry picked from commit 410d67f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5249
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃