Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existence check for hparams now uses underlying filesystem #5250

Merged
merged 6 commits into from
Jan 5, 2021
Merged

Existence check for hparams now uses underlying filesystem #5250

merged 6 commits into from
Jan 5, 2021

Conversation

kandluis
Copy link
Contributor

@kandluis kandluis commented Dec 23, 2020

What does this PR do?

Fixes #5249

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #5250 (241f71e) into master (d568533) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5250   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9976    9976           
======================================
  Hits         9294    9294           
  Misses        682     682           

@awaelchli awaelchli added feature Is an improvement or enhancement logger Related to the Loggers labels Dec 24, 2020
@awaelchli awaelchli added this to the 1.2 milestone Dec 24, 2020
@rohitgr7 rohitgr7 enabled auto-merge (squash) December 26, 2020 13:56
@rohitgr7 rohitgr7 disabled auto-merge December 26, 2020 16:39
@awaelchli awaelchli enabled auto-merge (squash) January 5, 2021 13:51
@Borda Borda added the ready PRs ready to be merged label Jan 5, 2021
@Borda
Copy link
Member

Borda commented Jan 5, 2021

@awaelchli pls check is it 1.2 or 1.1.x? the description says 1.2 but the target is master…

@Borda Borda added bug Something isn't working and removed feature Is an improvement or enhancement labels Jan 5, 2021
@Borda Borda modified the milestones: 1.2, 1.1.x Jan 5, 2021
@awaelchli awaelchli merged commit 410d67f into Lightning-AI:master Jan 5, 2021
Borda pushed a commit that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving meta tags hparams file in Tensorboard Logger can occur multiple times
5 participants