Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove outdated docs on CUDA_DEVICE_ORDER and CUDA_VISIBLE_DEVICES #5287

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #4924
Removes section in docs saying that lightning sets CUDA_DEVICE_ORDER and CUDA_VISIBLE_DEVICES for the user, which we do not do anymore.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the docs Documentation related label Dec 28, 2020
@SkafteNicki SkafteNicki added this to the 1.1.x milestone Dec 28, 2020
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #5287 (3afb530) into master (9ebbfec) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5287   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9950    9945    -5     
======================================
- Hits         9261    9259    -2     
+ Misses        689     686    -3     

@rohitgr7 rohitgr7 enabled auto-merge (squash) December 28, 2020 18:46
@rohitgr7 rohitgr7 merged commit eb1d61c into Lightning-AI:master Dec 28, 2020
@SkafteNicki SkafteNicki deleted the docs_remove_cuda_desc branch December 30, 2020 16:10
Borda pushed a commit that referenced this pull request Jan 6, 2021
Co-authored-by: Rohit Gupta <[email protected]>
(cherry picked from commit eb1d61c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does pytorch lightning set the CUDA_VISIBLE_DEVICES vaviable?
4 participants