Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply isort to pl_examples/ #5291

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

akihironitta
Copy link
Contributor

What does this PR do?

Part of #4805.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #5291 (0a91377) into master (eb1d61c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5291   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9950    9950           
======================================
  Hits         9261    9261           
  Misses        689     689           

@awaelchli awaelchli added refactor feature Is an improvement or enhancement and removed refactor labels Dec 29, 2020
@awaelchli awaelchli added this to the 1.2 milestone Dec 29, 2020
@rohitgr7 rohitgr7 merged commit 0c7c9e8 into Lightning-AI:master Dec 29, 2020
@rohitgr7 rohitgr7 mentioned this pull request Dec 29, 2020
30 tasks
Borda pushed a commit that referenced this pull request Jan 6, 2021
* Remove examples from isort ignore list

* Apply isort

(cherry picked from commit 0c7c9e8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants